Skip to content

chore: removed unused npm package from root #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Feb 9, 2022

Summary

Javascript SDK is a monorepo which contains the javascript SDK and supporting packages in packages subfolder. We initially had a parent npm package at root to manage subpackages together but its no longer being used. This PR removed that unused npm package and updates readme.

Test plan

All existing tests should pass

@coveralls
Copy link

coveralls commented Feb 9, 2022

Coverage Status

Coverage remained the same at 97.184% when pulling ed428b9 on zeeshan/remove-root-npm-package into b65b6e1 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.184% when pulling 909f432 on zeeshan/remove-root-npm-package into b65b6e1 on master.

@zashraf1985 zashraf1985 marked this pull request as ready for review February 10, 2022 02:02
@zashraf1985 zashraf1985 requested a review from a team as a code owner February 10, 2022 02:02
@zashraf1985 zashraf1985 removed their assignment Feb 10, 2022
Copy link
Contributor

@opti-jnguyen opti-jnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zashraf1985 zashraf1985 merged commit 8eedd63 into master Feb 10, 2022
@zashraf1985 zashraf1985 deleted the zeeshan/remove-root-npm-package branch February 10, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants