-
Notifications
You must be signed in to change notification settings - Fork 83
refactor: Replaced explicit typings with auto generated ones #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4917557
init
ozayr-zaviar e80f0a2
Event module made public
ozayr-zaviar 5a547fc
typings added in shared types
ozayr-zaviar c58cda9
lint fix
ozayr-zaviar 6bb85d0
ProjectConfigManagerConfig datafile type corrected
ozayr-zaviar a50e87d
object warning suppressed
ozayr-zaviar d4b3661
object parameter added in handleNewDatafile
ozayr-zaviar b59f8a0
index.d.ts removed
ozayr-zaviar c3f628e
typing synced with index.d.ts
ozayr-zaviar abf00e5
export types redundancy removed
ozayr-zaviar 01c95eb
notification center set to public
ozayr-zaviar 50039ab
addNotificationListener type exported in utils package
ozayr-zaviar 090e034
Merge branch 'master' into uzair/lite-typings
ozayr-zaviar 6d9982d
Notification changes
ozayr-zaviar 49a5246
seperate client and type for lite bundles added
ozayr-zaviar 331644b
fixed some more types
zashraf1985 72430ff
- removed unneeded SDKOptions interface
zashraf1985 90e4149
trying to fix testapp
zashraf1985 b1a6e11
Revert "trying to fix testapp"
zashraf1985 10fcd43
comments addressed
ozayr-zaviar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
export { | ||
UserAttributes, | ||
OptimizelyConfig, | ||
OptimizelyVariable, | ||
OptimizelyVariation, | ||
OptimizelyExperiment, | ||
OptimizelyFeature, | ||
OptimizelyDecisionContext, | ||
OptimizelyForcedDecision, | ||
EventTags, | ||
Event, | ||
EventDispatcher, | ||
DatafileOptions, | ||
OptimizelyOptions, | ||
UserProfileService, | ||
UserProfile, | ||
ListenerPayload, | ||
OptimizelyDecision, | ||
OptimizelyUserContext, | ||
NotificationListener, | ||
Config, | ||
Client, | ||
ActivateListenerPayload, | ||
TrackListenerPayload, | ||
NotificationCenter | ||
} from './shared_types' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDKOptions and OptimizelyOptions are not needed to be exposed. Config is enough for external usage