Skip to content

fix: FSC build CLIENT fix. #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2022
Merged

fix: FSC build CLIENT fix. #757

merged 4 commits into from
May 13, 2022

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented May 12, 2022 •
edited
Loading

Summary

  • FSC needs CLIENT to run js sdk, which was missing in our integration-test yaml. I have made it fixed, once this PR Is merged, we should have proper status of FSC in our checks.

Test plan

  • I have tested in our last checks and works fine. for now i have pointed to master branch which will be used to take configuration for running CI.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.185% when pulling 4f501d8 on sohail/fscfix into fc625f0 on master.

@msohailhussain msohailhussain changed the title investigating fsc build fix: FSC build CLIENT fix. May 12, 2022
@msohailhussain msohailhussain marked this pull request as ready for review May 12, 2022 20:00
@msohailhussain msohailhussain requested a review from a team as a code owner May 12, 2022 20:00
@zashraf1985 zashraf1985 merged commit aa11535 into master May 13, 2022
@zashraf1985 zashraf1985 deleted the sohail/fscfix branch May 13, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zashraf1985 zashraf1985 zashraf1985 approved these changes

Assignees

@msohailhussain msohailhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msohailhussain @coveralls @zashraf1985