Skip to content

[FSSDK-10198] making isOdpIntegrated public #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 20, 2024
Merged

[FSSDK-10198] making isOdpIntegrated public #930

merged 7 commits into from
May 20, 2024

Conversation

junaed-optimizely
Copy link
Contributor

Summary

Client should contain public facing API to provide information about ODP integration

Test plan

Existing test should pass

Issues

@junaed-optimizely junaed-optimizely requested a review from a team as a code owner May 17, 2024 17:10
@junaed-optimizely junaed-optimizely requested a review from jaeopt May 17, 2024 17:11
@coveralls
Copy link

coveralls commented May 17, 2024 •
edited
Loading

Coverage Status

coverage: 90.308%. remained the same
when pulling d9a6a9a on junaed/fssdk-10198-odp-not-integrated-error
into 43fea02 on master.

mikechu-optimizely
mikechu-optimizely requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small necessary change, but looks good.

jaeopt
jaeopt requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One required change

mikechu-optimizely
mikechu-optimizely approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mikechu-optimizely mikechu-optimizely changed the title Junaed/fssdk 10198 - making isOdpIntegrated public [FSSDK-10198] making isOdpIntegrated public May 20, 2024
This was referenced May 20, 2024
Merged
Closed
jaeopt
jaeopt approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junaed-optimizely junaed-optimizely merged commit 01b50a2 into master May 20, 2024
20 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10198-odp-not-integrated-error branch May 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@junaed-optimizely junaed-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@junaed-optimizely @coveralls @jaeopt @mikechu-optimizely