Skip to content

fix: Remove @babel/runtime as a peerDependency #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kirkeaton
Copy link
Contributor

Summary

Removes @babel/runtime as a peerDependency which appears to be unused. It was added in #761 but it's not clear why.

Test plan

Existing test should pass

@kirkeaton kirkeaton marked this pull request as ready for review June 8, 2024 00:26
@kirkeaton kirkeaton requested a review from a team as a code owner June 8, 2024 00:26
@mikechu-optimizely
Copy link
Contributor

Hiya @kirkeaton,

Thanks for the suggestion. We love slimming down the deps wherever possible. Could you let us know what problem this solves for your use case (management needs doc 🙄 😁 ).

@kirkeaton
Copy link
Contributor Author

Hi @mikechu-optimizely,

I'll do my best to summarize what I see as the problem. I believe that this dependency is not used within this project. I inspected the build artifacts and did not find it being used and it's not mentioned in the installation docs (here or here). Since it's listed as a peer dependency, developers may think that they need to install this dependency in their own project in order for this SDK to work properly.

Additionally, some package managers will output a warning message if a peer dependency is not installed. By removing it, this warning message will go away. Here's an example screenshot of the warning message:

Screen Shot 2024-06-18 at 12 36 44 PM

Hope this explanation helps.

@mikechu-optimizely
Copy link
Contributor

@kirkeaton That's super detailed. Thanks for taking your time to put in the PR and the description. I've created internal work item FSSDK-10320 which we'll fold this change into the next release.

@raju-opti
Copy link
Contributor

raju-opti commented Jul 3, 2024

Hi @kirkeaton , could you please read the CONTRIBUTING.md doc and sign the CLA form. Please ping me here after you have done so. We are not allowed to use any individual open source contribution without that agreement.

@kirkeaton
Copy link
Contributor Author

@raju-opti I believe I have already signed the CLA. optimizely/go-sdk#335 (comment)

@kirkeaton kirkeaton force-pushed the remove-babel-runtime branch from 4d03caf to 8154ccd Compare July 3, 2024 18:18
@coveralls
Copy link

Coverage Status

coverage: 90.307%. remained the same
when pulling 8154ccd on kirkeaton:remove-babel-runtime
into 3caaff3 on optimizely:master.

@raju-opti
Copy link
Contributor

Hello @kirkeaton , this has been merged as part of #942. This will be available in the next release. closing this PR.

@raju-opti raju-opti closed this Jul 5, 2024
@kirkeaton kirkeaton deleted the remove-babel-runtime branch July 5, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants