-
Notifications
You must be signed in to change notification settings - Fork 30
feat(ForcedDecisions): add forced-decisions APIs to OptimizelyUserContext #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 18 commits
8607ff2
e013fea
0b1f517
cd4176c
5c753aa
0fd717b
7e2400f
9cb1d03
ae48a61
6a9a5f0
60ae438
df1c82f
80e5026
979a0e7
d22ad11
a5843c2
f387f89
3557793
8797195
83ef326
b7b980d
280371c
9168430
2bb8937
0df9732
bc3bb03
7566d55
32122b7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -199,7 +199,23 @@ public function getVariationFromKeyByExperimentId($experimentId, $variationKey); | |
* @return FeatureVariable / null | ||
*/ | ||
public function getFeatureVariableFromKey($featureFlagKey, $variableKey); | ||
|
||
|
||
/** | ||
* Gets the variation associated with experiment or rollout in instance of given feature flag key | ||
* | ||
* @param string Feature flag key | ||
* @param string variation key | ||
* | ||
* @return Variation / null | ||
*/ | ||
public function getFlagVariationByKey($flagKey, $variationKey); | ||
|
||
/** | ||
* Returns map array of Flag key as key and Variations as value | ||
* | ||
* @return array | ||
*/ | ||
public function getFlagVariationsMap(); | ||
Comment on lines
+211
to
+218
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Implication of these new interface functions to existing clients with custom ProjectConfig? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it will simply return flag variations map do i have to add something other then comment above? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No. I think it's good as is. |
||
/** | ||
* Determines if given experiment is a feature test. | ||
* | ||
|
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.