Skip to content

Create script to generate html docs with sphinx #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2020

Conversation

yavorona
Copy link
Contributor

@aliabbasrizvi please take a look at this pr.

Thanks!

Summary

  • Created script to autogenerate documentation
  • Added sphinx/build to .gitignore
  • Added minor necessary changes to README.md and CONTRIBUTING.md for proper conversion to .rst

image

Test plan

None at the moment

Issues

OASIS-6178

Add minor changes to README.md and CONTRIBUTING.md for proper conversion to .rst
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mostly cosmetic changes needed.

.gitignore Outdated
@@ -23,3 +23,6 @@ datafile.json

# OSX folder metadata
*.DS_Store

# Sphinx documentation
docs/build/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. Add new line at end of file.

# -- Project information -----------------------------------------------------

project = 'Python SDK'
copyright = '2020, Optimizely, Inc'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. 2016-2020, Optimizely, Inc.

Comment on lines 11 to 13



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eliminate these extraneous lines.

Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just fix the new line issue before merging.

Thanks.

.gitignore Outdated

# Sphinx documentation
docs/build/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. Extraneous line here.

# Add any paths that contain custom static files (such as style sheets) here,
# relative to this directory. They are copied after the builtin static files,
# so a file named "default.css" will overwrite the builtin "default.css".
# html_static_path = ['_static']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. new line needed here.

@yavorona yavorona merged commit 1a59c06 into sphinx-docs Mar 29, 2020
@yavorona yavorona deleted the pnguen/sphinx_script branch March 29, 2020 03:52
yavorona added a commit that referenced this pull request May 12, 2020
* Create script to generate html docs with sphinx
Add minor changes to README.md and CONTRIBUTING.md for proper conversion to .rst

* Address comments

* Clean up

Co-authored-by: Polina Nguen <[email protected]>
yavorona added a commit that referenced this pull request May 14, 2020
* Create script to generate html docs with sphinx
Add minor changes to README.md and CONTRIBUTING.md for proper conversion to .rst

* Address comments

* Clean up

Co-authored-by: Polina Nguen <[email protected]>
yavorona added a commit that referenced this pull request May 14, 2020
* Add docs.txt to requirements (#242)

Co-authored-by: Polina Nguen <[email protected]>

* Create script to generate html docs with sphinx (#243)

* Create script to generate html docs with sphinx
Add minor changes to README.md and CONTRIBUTING.md for proper conversion to .rst

* Address comments

* Clean up

Co-authored-by: Polina Nguen <[email protected]>

* Include docstrings from bucketer.py and decision_service.py to the docs (#244)

* Include docstrings from bucketer.py and decision_service.py to the docs

* Fix Travis failure

Co-authored-by: Polina Nguen <[email protected]>

* Add docstrings from config_manager.py and optimizely_config.py to docs (#245)

Update buckering_algorithm to exclude namedtuble docstrings

Co-authored-by: Polina Nguen <[email protected]>

* Added optimizely.py, event_dispatcher.py, and event_builder.py docstrings to the docs (#246)

* Added optimizely.py to docs

* Returned to having private methods included for now.

* Added optimizely.py, event_builder.py, and event_dispatcher.py to the docs

Co-authored-by: Polina Nguen <[email protected]>

* Added logger.py and user_profile.py docstrings to the docs. (#247)

* Added optimizely.py to docs

* Returned to having private methods included for now.

* Added optimizely.py, event_builder.py, and event_dispatcher.py to the docs

* Added user_profile.py and logger.py docstrings to docs
Moved all api_reference components into one rst file

Co-authored-by: Polina Nguen <[email protected]>

* Adding version of python sdk to docs (#249)

* Added optimizely.py to docs

* Returned to having private methods included for now.

* Added optimizely.py, event_builder.py, and event_dispatcher.py to the docs

* Add version to docs

* Update branch

Co-authored-by: Polina Nguen <[email protected]>

* Remove private methods (#250)

* Update sphinx docs per OASIS-6317 (#252)

* Change pip8 to flake8

* Update contributing link to work in sphinx docs

* Remove Event Builder

* Change “Bucketing Algorithm Methods” to “Bucketing”

* Update project name

* Include README to table of contents

* Create readme.rst for readme.md

* Add Optimizely logo to docs (#256)

* [OASIS-6317] - Fix README.md format (#255)

* Fix table in Advanced configuration

* Fix anchor

* Added README.md for generating sphinx docs (#257)

* Create README for sphinx docs

* Fix spelling

* Update README.md

Add title

* Incorporate Ali's comments

* chore(build): Making sure docs is excluded from build (#258)

* Removed Bucketing Algorithm Section and Added Description of Class Init Options in class Optimizely (#259)

* Remove bucketing algorithm section

* Add __init__ to class optimizely.optimizely.Optimizely

* Specified master_doc

Co-authored-by: Ali Abbas Rizvi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants