Skip to content

enhancement: Remove mmh3 external dependency and use internal pymmh3 in place #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
The-inside-man merged 9 commits into from
Nov 3, 2021
Merged

enhancement: Remove mmh3 external dependency and use internal pymmh3 in place #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8b1514a
changes for lite version testing
The-inside-man Oct 18, 2021
c293c97
Update call from pymmh3 to mmh3
The-inside-man Oct 21, 2021
b259dcd
Adding back in libs and will remove one by one.
The-inside-man Oct 21, 2021
90720ca
remove idna lib
The-inside-man Oct 21, 2021
057c249
remove cryptography
The-inside-man Oct 21, 2021
bcffa0b
Re-adding cryptography as pypy has issues and removing openSSL lib.
The-inside-man Oct 22, 2021
e092d9d
Removing pyrsistent as test
The-inside-man Oct 22, 2021
33f14c0
Re-adding pyrsistent as it casues issues in python 3.4 and pypy with …
The-inside-man Oct 22, 2021
7d0ce97
Update core.txt requirements to only ommit mmh3
The-inside-man Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions optimizely/bucketer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@

import math

try:
import mmh3
except ImportError:
from .lib import pymmh3 as mmh3
from .lib import pymmh3 as mmh3


MAX_TRAFFIC_VALUE = 10000
Expand Down
1 change: 0 additions & 1 deletion requirements/core.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
jsonschema==3.2.0
pyrsistent==0.16.0
mmh3==2.5.1
requests>=2.21
pyOpenSSL>=19.1.0
cryptography>=2.8.0
Expand Down
5 changes: 2 additions & 3 deletions tests/test_bucketing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,14 @@
# limitations under the License.

import json
import mmh3
import mock
import random

from optimizely import bucketer
from optimizely import entities
from optimizely import logger
from optimizely import optimizely
from optimizely.lib import pymmh3
from optimizely.lib import pymmh3 as mmh3

from . import base

Expand Down Expand Up @@ -215,7 +214,7 @@ def test_hash_values(self):

for i in range(10):
random_value = str(random.random())
self.assertEqual(mmh3.hash(random_value), pymmh3.hash(random_value))
self.assertEqual(mmh3.hash(random_value), mmh3.hash(random_value))


class BucketerWithLoggingTest(base.BaseTest):
Expand Down