Skip to content

fix: odp issues identified by FSC #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 26, 2023
Merged

fix: odp issues identified by FSC #412

merged 11 commits into from
Jan 26, 2023

Conversation

andrewleap-optimizely
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely commented Jan 13, 2023 •
edited
Loading

Summary

Fix some issues identified by FSC tests

  • extraneous identify calls
  • invalid opti instance checks in odp method
  • duplicate integration key handling
  • cache size 0 fix
  • missing feature variation variable

Test plan

  • All tests pass

Ticket

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review January 26, 2023 14:06
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner January 26, 2023 14:06
Mat001
Mat001 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, we went through this. looks ok

@Mat001 Mat001 requested a review from jaeopt January 26, 2023 19:06
jaeopt
jaeopt approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a suggestion about adding a test.

optimizely/optimizely.py
# error is logged in create_user_context
if user_context is None:
return None
user_context = OptimizelyUserContext(self, self.logger, user_id, attributes, False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a unit test validating we do not fire ODP events with any legacy APIs.

@Mat001 Mat001 merged commit 6be3cbd into master Jan 26, 2023
@Mat001 Mat001 deleted the aleap/odp_fixes branch January 26, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @Mat001 @jaeopt