Skip to content

Renames notification-center methods #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2018
Merged

Renames notification-center methods #117

merged 1 commit into from
Jun 29, 2018

Conversation

rashidsp
Copy link
Contributor

  • Renames 'clear_notifications' to 'clear_notification_listeners' and 'clean_all_notifications' to 'clear_all_notification_listeners'.
  • Added deprecated methods along '@deprecated' meta tag.
  • Added meta tags.

mikeproeng37
mikeproeng37 approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing this.

@mikeproeng37
Copy link
Contributor

build

@mikeproeng37 mikeproeng37 merged commit b2a4883 into master Jun 29, 2018
@oakbani oakbani deleted the rashid/NC-deprecated-methods branch July 2, 2018 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rashidsp @mikeproeng37