fix(track): Send decisions for all experiments using an event when using track #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
mikeproeng37
suggested changes
Aug 27, 2018
spec/event_builder_spec.rb
Outdated
| @@ -253,6 +253,18 @@ | |||
| expect(conversion_event.http_verb).to eq(:post) | |||
| end | |||
|
|
|||
| it 'should create_conversion_event when Event is used in multiple experiments' do | |||
| @expected_conversion_params[:visitors][0][:snapshots][0][:decisions].push( | |||
There was a problem hiding this comment.
The setup of this test is not very clear from just looking at this. Can you split this out into its own scenario with its own setup? Specifically, the scenario testing event tracking with multiple experiments.
lib/optimizely/event_builder.rb
Outdated
|
|
||
| conversion_event_params.push(single_snapshot) | ||
| event_object[:tags] = event_tags |
There was a problem hiding this comment.
Please add a check if event_tags has any item in it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.