Skip to content

EventBuilder uses the same logger as Project #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/optimizely.rb
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def initialize(datafile, event_dispatcher = nil, logger = nil, error_handler = n
end

@decision_service = DecisionService.new(@config, @user_profile_service)
@event_builder = EventBuilder.new(@config, logger)
@event_builder = EventBuilder.new(@config, @logger)
@notification_center = NotificationCenter.new(@logger, @error_handler)
end

Expand Down
13 changes: 13 additions & 0 deletions spec/project_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,19 @@ class InvalidErrorHandler; end
expect(project_instance.event_dispatcher).to have_received(:dispatch_event).with(Optimizely::Event.new(:post, conversion_log_url, params, post_headers)).once
end

it 'should properly track an event with tags even when the project does not have a custom logger' do
project_instance = Optimizely::Project.new(config_body_JSON)

params = @expected_track_event_params
params[:visitors][0][:snapshots][0][:decisions][0][:variation_id] = '111129'
params[:visitors][0][:snapshots][0][:events][0][:tags] = {revenue: 42}

project_instance.config.set_forced_variation('test_experiment', 'test_user', 'variation')
allow(project_instance.event_dispatcher).to receive(:dispatch_event).with(instance_of(Optimizely::Event))
project_instance.track('test_event', 'test_user', nil, revenue: 42)
expect(project_instance.event_dispatcher).to have_received(:dispatch_event).with(Optimizely::Event.new(:post, conversion_log_url, params, post_headers)).once
end

it 'should log a message if an exception has occurred during dispatching of the event' do
allow(project_instance.event_dispatcher).to receive(:dispatch_event).with(any_args).and_raise(RuntimeError)
project_instance.track('test_event', 'test_user')
Expand Down