Skip to content

Updating libraries for Ruby SDK #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2018
Merged

Updating libraries for Ruby SDK #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b136c1f
Updating libraries for Ruby SDK
aliabbasrizvi Aug 28, 2018
21a3f7f
Addressing rubocop feedback
aliabbasrizvi Aug 28, 2018
e2a21a5
Addressing Rubocop comment
aliabbasrizvi Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@ inherit_from: .rubocop_todo.yml
AllCops:
TargetRubyVersion: 2.3

Metrics/AbcSize:
Enabled: false
Layout/SpaceInsideHashLiteralBraces:
EnforcedStyle: no_space

Metrics/CyclomaticComplexity:
Metrics/AbcSize:
Enabled: false

Metrics/PerceivedComplexity:
Metrics/BlockLength:
Enabled: false

Metrics/ClassLength:
Enabled: false

Metrics/BlockLength:
Metrics/CyclomaticComplexity:
Enabled: false

Metrics/LineLength:
Expand All @@ -27,17 +27,17 @@ Metrics/MethodLength:
Metrics/ModuleLength:
Enabled: false

Style/Documentation:
Metrics/PerceivedComplexity:
Enabled: false

Style/SignalException:
EnforcedStyle: only_raise

Layout/SpaceInsideHashLiteralBraces:
EnforcedStyle: no_space

Naming/VariableNumber:
Enabled: false

Style/Documentation:
Enabled: false

Style/RescueStandardError:
Enabled: false

Style/SignalException:
Enabled: false
5 changes: 2 additions & 3 deletions optimizely-sdk.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

# frozen_string_literal: true

require_relative 'lib/optimizely/version'
Expand All @@ -19,8 +18,8 @@ Gem::Specification.new do |spec|

spec.add_development_dependency 'bundler', '~> 1.10'
spec.add_development_dependency 'rake', '~> 12.0'
spec.add_development_dependency 'rspec', '~> 3.7.0'
spec.add_development_dependency 'rubocop', '~> 0.56.0'
spec.add_development_dependency 'rspec', '~> 3.8.0'
spec.add_development_dependency 'rubocop', '~> 0.58.0'

spec.add_runtime_dependency 'httparty', '~> 0.11'
spec.add_runtime_dependency 'json-schema', '~> 2.6'
Expand Down