fix(datafile-parsing): Prevent newer versions datafile #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
suggested changes
Sep 4, 2018
lib/optimizely.rb
Outdated
| @@ -64,17 +64,15 @@ def initialize(datafile, event_dispatcher = nil, logger = nil, error_handler = n | |||
|
|
|||
| begin | |||
| @config = ProjectConfig.new(datafile, @logger, @error_handler) | |||
| rescue | |||
| rescue InvalidDatafileVersionError => e | |||
There was a problem hiding this comment.
Same comment as on the Python PR, please consolidate into one rescue and change the message based on the type of the exception
mikeproeng37
reviewed
Sep 4, 2018
lib/optimizely.rb
Outdated
| @is_valid = false | ||
| @logger = SimpleLogger.new | ||
| @logger.log(Logger::ERROR, InvalidDatafileVersionError.new.message) | ||
| @logger.log(Logger::ERROR, InvalidInputError.new('datafile').message) |
There was a problem hiding this comment.
Also, please pass the error to the error_handler instance
|
Ran these compat-suite tests locally and they pass: https://github.com/optimizely/fullstack-sdk-compatibility-suite/pull/134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.