EventBuilder uses the same logger as Project #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously, `EventBuilder` was instantiated by `Project` with the value of the `logger` local. However, when `Project` was not instantiated with a custom `logger`, `EventBuilder` would be instantiated with `nil` logger, which would cause `track` to raise a `NoMethodError` when called with tags. - This commit changes the `Project` constructor to pass the `@logger` instance variable to `EventBuilder`, so that they are using the same logger, custom or otherwise. - The added spec fails prior to the constructor change
|
Closed with #122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tests on #122