refact(API): Adds missing input validations in all API methods and validates empty user Id. #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidates empty user Id.
|
build |
|
build |
mikeproeng37
suggested changes
Nov 14, 2018
lib/optimizely.rb
Outdated
| }, @logger, Logger::ERROR | ||
| ) | ||
|
|
||
| unless user_id.is_a?(String) |
There was a problem hiding this comment.
I'd rather we refactor a bit and avoid using this same logic everywhere in the code. Let's mimic what the C# SDK does here: https://github.com/optimizely/csharp-sdk/blob/master/OptimizelySDK/Optimizely.cs#L642
|
it's ready for review. |
mikeproeng37
suggested changes
Nov 15, 2018
lib/optimizely.rb
Outdated
| @@ -258,6 +258,8 @@ def is_feature_enabled(feature_flag_key, user_id, attributes = nil) | |||
| }, @logger, Logger::ERROR | |||
| ) | |||
|
|
|||
| return false unless user_inputs_valid?(attributes) | |||
There was a problem hiding this comment.
Can we combine Optimizely::Helpers::Validator.inputs_valid? with user_inputs_valid?? Seems like we could just put all user inputs into one dictionary and have them all validated
There was a problem hiding this comment.
Combined validations: rashid/input-validations...rashid/input-validations-2
It resulted in a big change plz confirm to continue with this PR?
mikeproeng37
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.