Skip to content

feat(DecisionListener): Adds experiment decision listener. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aliabbasrizvi merged 7 commits into from
Mar 26, 2019
Merged

feat(DecisionListener): Adds experiment decision listener. #159

aliabbasrizvi merged 7 commits into from
Mar 26, 2019

Conversation

@rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Mar 8, 2019 •
edited
Loading

Summary

Implemented onDecisionListener in following APIs:

  • activate
  • get_variation

Test plan

Unit tests for OnDecisionListener

Issues

  • OASIS-4233

@coveralls
Copy link

coveralls commented Mar 8, 2019

Coverage Status

Coverage increased (+0.002%) to 99.947% when pulling 0cd8d5e on rashid/experiment-decision-listener into c2a0931 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 8, 2019

Coverage Status

Coverage increased (+0.002%) to 99.947% when pulling 0cd8d5e on rashid/experiment-decision-listener into c2a0931 on master.

@coveralls
Copy link

coveralls commented Mar 8, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.0003%) to 99.947% when pulling 1293b08 on rashid/experiment-decision-listener into ca0a3fe on master.

@rashidsp rashidsp requested a review from a team March 8, 2019 14:42
@aliabbasrizvi
Copy link
Contributor

aliabbasrizvi commented Mar 8, 2019 •
edited
Loading

NOTE: Do not merge until 3.0.0 release.

aliabbasrizvi
aliabbasrizvi approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliabbasrizvi aliabbasrizvi merged commit c3ed2ab into master Mar 26, 2019
@aliabbasrizvi aliabbasrizvi deleted the rashid/experiment-decision-listener branch March 26, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rashidsp @coveralls @aliabbasrizvi