Skip to content

handle error with error handler in async scheduler #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

handle error with error handler in async scheduler #248

merged 1 commit into from
May 7, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented May 4, 2020

Summary

Async scheduler logs errors but does not pass it to an error handler. This does not allow this error to be reported in client's error reporting services. This PR sends these errors to the error_handler as well.

Test plan

Unit tests should pass

Issues

@oakbani oakbani requested a review from a team as a code owner May 4, 2020 12:46
@oakbani oakbani removed their assignment May 4, 2020
@oakbani oakbani requested a review from msohailhussain May 4, 2020 12:46
@coveralls
Copy link

coveralls commented May 4, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 99.492% when pulling eae387f on oakbani/async-scheduler-error-handler into 1c19b8e on master.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 3d6b45c into master May 7, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the oakbani/async-scheduler-error-handler branch May 7, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees
No one assigned
Labels
🤖 20 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oakbani @coveralls @thomaszurkan-optimizely @optimizely-codereview-bot