Skip to content

refact: avoid real http calls in unit tests #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2020
Merged

refact: avoid real http calls in unit tests #249

merged 3 commits into from
May 12, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented May 5, 2020

Summary

Some of the unit tests in project_spec make real http call to cdn.optimizely.com to test config manager. We mock them to avoid real http connections.

Test plan

All unit tests should continue to pass.

Issues

@oakbani oakbani requested a review from a team as a code owner May 5, 2020 11:19
@oakbani oakbani removed their assignment May 5, 2020
@oakbani oakbani requested a review from msohailhussain May 5, 2020 11:20
@coveralls
Copy link

coveralls commented May 5, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0009%) to 99.493% when pulling 6dcb02a on oakbani/mock-real-http into 3d6b45c on master.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 8c14502 into master May 12, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the oakbani/mock-real-http branch May 12, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oakbani @coveralls @thomaszurkan-optimizely @optimizely-codereview-bot