fix(logs): Fixing log messages #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimizely-codereview-bot
added
🤖 4 hrs
🤖 8 hrs
🤖 12 hrs
and removed
🤖 4 hrs
🤖 8 hrs
labels
oakbani
changed the title
aliabbasrizvi
suggested changes
Jul 9, 2020
| @@ -810,7 +810,7 @@ def get_feature_variable_for_variation(feature_flag_key, feature_enabled, variat | |||
| end | |||
| else | |||
| @logger.log(Logger::DEBUG, | |||
| "Feature '#{feature_flag_key}' for variation '#{variation['key']}' is not enabled. Returning the default variable value '#{variable_value}'.") | |||
| "Feature '#{feature_flag_key}' is not enabled for user '#{user_id}'. Returning the default variable value '#{variable_value}'.") | |||
There was a problem hiding this comment.
The changes are incomplete here.
On line 809 it should say Variable value is not defined. Returning the default variable value <variable value> for variable <variable key>
On line 916 it should say User <user ID> was not bucketed into experiment or rollout for feature flag <feature flag key>. Returning the default variable value <variable value>
lib/optimizely/audience.rb
Outdated
| def user_in_experiment?(config, experiment, attributes, logger) | ||
| # Determine for given experiment if user satisfies the audiences for the experiment. | ||
| def user_meets_audience_conditions?(config, experiment, attributes, logger, logging_hash = nil, logging_key = nil) | ||
| # Determine for given experiment/rollout rule if user satisfies the audiences. |
There was a problem hiding this comment.
nit. satisfies the audience conditions.
lib/optimizely/audience.rb
Outdated
| # | ||
| # config - Representation of the Optimizely project config. | ||
| # experiment - Experiment for which visitor is to be bucketed. | ||
| # experiment - Experiment/Rollout rule for which visitor is to be bucketed. |
There was a problem hiding this comment.
nit. ...in which user is to be bucketed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan