refactor: Added more logs to datafile manager #260
Conversation
| headers = {} | ||
| headers['Content-Type'] = 'application/json' | ||
| headers['If-Modified-Since'] = @last_modified if @last_modified | ||
| headers['Authorization'] = "Bearer #{@access_token}" unless @access_token.nil? |
There was a problem hiding this comment.
You are right, that is exactly what i did. This is why i cleansed the headers before logging and replaced the value of Authorization header to *** right below this line.
There was a problem hiding this comment.
ha, i saw that. i deleted my comment. but, it would be nice to add a simple logger spy test to see that was outputted :)
There was a problem hiding this comment.
yup.. good idea.. doing that now.
| if response_code >= 200 && response_code < 400 | ||
| @logger.log(Logger::DEBUG, 'Successfully fetched datafile, generating Project config') | ||
| config = DatafileProjectConfig.create(response.body, @logger, @error_handler, @skip_json_validation) | ||
| @last_modified = response[Helpers::Constants::HTTP_HEADERS['LAST_MODIFIED']] |
There was a problem hiding this comment.
nit: what happens if last modified is nil?
There was a problem hiding this comment.
It is assigned as nil. I just moved this line of code inside the check. assuming it was working correctly earlier as well without a nil check
| headers = {} | ||
| headers['Content-Type'] = 'application/json' | ||
| headers['If-Modified-Since'] = @last_modified if @last_modified | ||
| headers['Authorization'] = "Bearer #{@access_token}" unless @access_token.nil? |
There was a problem hiding this comment.
You are right, that is exactly what i did. This is why i cleansed the headers before logging and replaced the value of Authorization header to *** right below this line.
Summary
Added more debug logs to datafile manager to make debugging easy.
Test plan
All Existing unit and FSC tests should pass