Skip to content

feat: Add Semantic Version support #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Aug 19, 2020

Summary

This adds support for Semantic Versioning in Audience Evaluation.

Test plan

Added unit tests.
Verified with FSC semantic version tests locally.

Issues

@oakbani oakbani requested a review from a team as a code owner August 19, 2020 13:27
@oakbani oakbani removed their assignment Aug 19, 2020
@coveralls
Copy link

coveralls commented Aug 19, 2020

Coverage Status

Coverage increased (+0.02%) to 99.583% when pulling 7fb55b4 on oakbani/semantic-version into dd5a244 on master.

Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add ge and le along with tests?

Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit bc09647 into master Aug 27, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the oakbani/semantic-version branch August 27, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants