Skip to content

feat: Add datafile accessor to config #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2020
Merged

feat: Add datafile accessor to config #268

merged 2 commits into from
Aug 26, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Aug 20, 2020

Summary

Adds datafile string inside project config and optimizely config.

Test plan

Added unit tests.
All checks should pass.

Issues

@oakbani oakbani requested a review from a team as a code owner August 20, 2020 12:55
@oakbani oakbani removed their assignment Aug 20, 2020
@oakbani oakbani requested a review from msohailhussain August 20, 2020 12:55
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.567% when pulling 1cb29f1 on oakbani/df-accessor into 5e02748 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.567% when pulling 1cb29f1 on oakbani/df-accessor into 5e02748 on master.

@coveralls
Copy link

coveralls commented Aug 20, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0004%) to 99.567% when pulling 1cb29f1 on oakbani/df-accessor into 5e02748 on master.

@oakbani
Copy link
Contributor Author

oakbani commented Aug 21, 2020

Testapp PR should be merged before this one https://github.com/optimizely/ruby-testapp/pull/66

msohailhussain
msohailhussain suggested changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address. get_datafile should be a method, it' shouldn't have a sub-property.

msohailhussain
msohailhussain approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pawels-optimizely
pawels-optimizely approved these changes Aug 26, 2020
View reviewed changes
Copy link

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

msohailhussain
msohailhussain approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pawels-optimizely pawels-optimizely merged commit dd5a244 into master Aug 26, 2020
@pawels-optimizely pawels-optimizely deleted the oakbani/df-accessor branch August 26, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

@thomaszurkan-optimizely thomaszurkan-optimizely Awaiting requested review from thomaszurkan-optimizely

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

Assignees

@oakbani oakbani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oakbani @coveralls @msohailhussain @pawels-optimizely @optimizely-codereview-bot