Feat: added SDKkey and environmentKey in datafile #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozayr-zaviar
changed the title
| @@ -38,6 +38,8 @@ class DatafileProjectConfig < ProjectConfig | |||
| attr_reader :anonymize_ip | |||
| attr_reader :bot_filtering | |||
| attr_reader :revision | |||
| attr_reader :sdk_key | |||
zashraf1985
previously requested changes
Jun 16, 2021
| @@ -194,6 +198,26 @@ def experiment_running?(experiment) | |||
| RUNNING_EXPERIMENT_STATUS.include?(experiment['status']) | |||
| end | |||
|
|
|||
| def get_sdk_key() | |||
There was a problem hiding this comment.
why create these getters when you have already declared read only attributes and using those directly?
msohailhussain
dismissed
zashraf1985’s stale review
changes are made but zeeshan is OFF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All unit tests and FSC tests should pass