Skip to content

typo fixups in bucketer.rb #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

bradenchime
Copy link

@bradenchime bradenchime commented Mar 22, 2022

Summary

Was reading through the documentation and came across 2 simple typos

Test plan

no testing required, just comments

was reading through the documentation and came across 2 simple typos
Copy link

@opti-jnguyen opti-jnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch - LGTM!

@bradenchime
Copy link
Author

@thomaszurkan-optimizely @opti-jnguyen anything I need to do to get this merged?

@zashraf1985
Copy link
Contributor

@bradenchime Thanks for contributing. The required status checks must pass before we get access to merge. Our current setup does not run checks automatically on PRs opened by external contributors. I need to spend some time to trigger the tests on this. I am scheduling this for next week. In the meantime, it will be great if you can sign our Contributor license agreement here if not done already. Thanks again for contributing.

@bradenchime
Copy link
Author

@zashraf1985 thanks for the prompt on signing the license, I have completed that now!

@bradenchime
Copy link
Author

@zashraf1985 I see this is still open, anything else needed on my end?

@bradenchime
Copy link
Author

@opti-jnguyen anything else to be done here?

mikechu-optimizely added a commit that referenced this pull request Aug 7, 2023
@mikechu-optimizely
Copy link
Contributor

Closing this PR with change now in #337

mikechu-optimizely added a commit that referenced this pull request Aug 8, 2023
* Add devcontainer config

* Add Ruby flavor GH Issue templates

* Add gitlens to devcontainer

* Add PR #298 doc fix

* Add GitLense to devcontainer

* Testing updates to ruby CI

* Fix linting item

* Rollback CI changes

* Add suggested setup from @andrewleap-optimizely

* fix for solargraph extension

---------

Co-authored-by: Andy Leap <[email protected]>
@Mat001 Mat001 reopened this Sep 25, 2023
@Mat001
Copy link
Contributor

Mat001 commented Sep 25, 2023

This fix has been applied and merged after updating the branch.

@Mat001 Mat001 closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants