-
Notifications
You must be signed in to change notification settings - Fork 28
typo fixups in bucketer.rb #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
was reading through the documentation and came across 2 simple typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch - LGTM!
@thomaszurkan-optimizely @opti-jnguyen anything I need to do to get this merged? |
@bradenchime Thanks for contributing. The required status checks must pass before we get access to merge. Our current setup does not run checks automatically on PRs opened by external contributors. I need to spend some time to trigger the tests on this. I am scheduling this for next week. In the meantime, it will be great if you can sign our Contributor license agreement here if not done already. Thanks again for contributing. |
@zashraf1985 thanks for the prompt on signing the license, I have completed that now! |
@zashraf1985 I see this is still open, anything else needed on my end? |
@opti-jnguyen anything else to be done here? |
Closing this PR with change now in #337 |
* Add devcontainer config * Add Ruby flavor GH Issue templates * Add gitlens to devcontainer * Add PR #298 doc fix * Add GitLense to devcontainer * Testing updates to ruby CI * Fix linting item * Rollback CI changes * Add suggested setup from @andrewleap-optimizely * fix for solargraph extension --------- Co-authored-by: Andy Leap <[email protected]>
This fix has been applied and merged after updating the branch. |
Summary
Was reading through the documentation and came across 2 simple typos
Test plan
no testing required, just comments