Skip to content

feat: add odp event manager #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 20, 2022
Merged

feat: add odp event manager #312

merged 6 commits into from
Sep 20, 2022

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

OdpEventManager provides internal services for sending ODP events to the ODP server.

  • adds default values to identifiers and data fields for all events.
  • stores requested events if they cannot be sent to the server.
  • stored events are dispatched when resources are available.

Test plan

  • added odp_event_manager_spec.rb

Ticket

OASIS-8445

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review September 12, 2022 20:38
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner September 12, 2022 20:38
jaeopt
jaeopt requested changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! A few small changes suggested.

jaeopt
jaeopt requested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those small changes again :)

jaeopt
jaeopt approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zashraf1985
zashraf1985 suggested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! Your code is always beautiful and well crafted. This looks great overall. I have just added a few random suggestions here and there.

zashraf1985
zashraf1985 approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jaeopt
jaeopt approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit 3579f5d into master Sep 20, 2022
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/add_odp_event_manager branch September 20, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@zashraf1985 zashraf1985 Awaiting requested review from zashraf1985

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @zashraf1985 @jaeopt