feat: add notification center registry #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mat001
approved these changes
Feb 8, 2023
| @sdk_settings.odp_segments_cache ||= LRUCache.new( | ||
| @sdk_settings.segments_cache_size, | ||
| @sdk_settings.segments_cache_timeout_in_secs | ||
| if !@sdk_settings.odp_disabled && @sdk_settings.odp_segment_manager.nil? |
There was a problem hiding this comment.
I think I'd suggest commenting this same as you did in Py:
"no need to instantiate a cache if a custom cache or segment manager is provided."
| @@ -1936,4 +1937,21 @@ module OptimizelySpec | |||
| # SEND_FLAG_DECISIONS_DISABLED_CONFIG['sendFlagDecisions'] = false | |||
|
|
|||
| CONFIG_DICT_WITH_INTEGRATIONS_JSON = JSON.dump(CONFIG_DICT_WITH_INTEGRATIONS) | |||
|
|
|||
| def self.deep_clone(obj) | |||
There was a problem hiding this comment.
What is the purpose of cloning, is it an equivalent of python's deepcpy?
There was a problem hiding this comment.
That's exactly right. Allowing us to manually modify the datafiles in one test without effecting other tests.
andrewleap-optimizely
deleted the
aleap/add_notification_center_registry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create a private registry of NotificationCenters for internal use.
Test plan
added tests to
Ticket
FSSDK-8775