Skip to content

[FSSDK-8956] docs: change full stack to feature experimentation #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

  • Updates readme and optimizely-sdk.gemspec replacing Full Stack with Feature Experimentation

Test plan

All tests pass

Ticket

FSSDK-8956

@@ -146,7 +152,7 @@ A notification signal will be triggered whenever a _new_ datafile is fetched and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, line 144: use block code style instead of in-line code style for notification_center.add_notification_listener(Optimizely::NotificationCenter::NOTIFICATION_TYPES[:OPTIMIZELY_CONFIG_UPDATE], @callback)

Copy link

@russell-loube-optimizely russell-loube-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤠

@andrewleap-optimizely andrewleap-optimizely merged commit c6c50d3 into master Mar 10, 2023
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/change_fs_to_fx branch March 10, 2023 21:40
andrewleap-optimizely added a commit that referenced this pull request Mar 13, 2023
* change full stack to feature experimentation
andrewleap-optimizely added a commit that referenced this pull request Mar 13, 2023
* ci: cleanup broken/slow actions (#309)

* fix source clear

* fix readme build badge

* remove readme url check

* updated prefix of ticket-check action (#315)

* [FSSDK-8956] docs: change full stack to feature experimentation (#327)

* change full stack to feature experimentation

* bump version and update changelog (#328)

---------

Co-authored-by: Muhammad Shaharyar <shairy333@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants