[FSSDK-8956] docs: change full stack to feature experimentation #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewleap-optimizely
requested review from
griffincox-optimizely and
russell-loube-optimizely
| [BatchEventProcessor](https://github.com/optimizely/ruby-sdk/blob/master/lib/optimizely/event/batch_event_processor.rb) is a batched implementation of the [EventProcessor](https://github.com/optimizely/ruby-sdk/blob/master/lib/optimizely/event/event_processor.rb) | ||
| * Events passed to the `BatchEventProcessor` are immediately added to a `Queue`. | ||
There was a problem hiding this comment.
Nit, line 144: use block code style instead of in-line code style for notification_center.add_notification_listener(Optimizely::NotificationCenter::NOTIFICATION_TYPES[:OPTIMIZELY_CONFIG_UPDATE], @callback)
Mat001
requested changes
Mar 10, 2023
Mat001
approved these changes
Mar 10, 2023
andrewleap-optimizely
added a commit
that referenced
this pull request
Mar 13, 2023
* change full stack to feature experimentation
andrewleap-optimizely
added a commit
that referenced
this pull request
Mar 13, 2023
* ci: cleanup broken/slow actions (#309) * fix source clear * fix readme build badge * remove readme url check * updated prefix of ticket-check action (#315) * [FSSDK-8956] docs: change full stack to feature experimentation (#327) * change full stack to feature experimentation * bump version and update changelog (#328) --------- Co-authored-by: Muhammad Shaharyar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All tests pass
Ticket
FSSDK-8956