Skip to content

Feature - IP Anonymization #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2017

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Oct 5, 2017

No description provided.

🖊️ Param added in commonparams in event_builder.rb
🖊️ Unit test cases updated in event_builder_spec.rb and project_spec.rb
@optibot
Copy link

optibot commented Oct 5, 2017

Can one of the admins verify this patch?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 99.787% when pulling 8a3ccf7 on msohailhussain:anonymize_ip into 9f5a688 on optimizely:master.

@mikeproeng37 mikeproeng37 requested a review from mauerbac October 5, 2017 18:01
Copy link
Contributor

@mauerbac mauerbac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Passed our end to end tests.

@mauerbac mauerbac merged commit a1e6b6f into optimizely:master Oct 6, 2017
rashidsp pushed a commit to msohailhussain/ruby-sdk that referenced this pull request Dec 12, 2017
rashidsp pushed a commit to msohailhussain/ruby-sdk that referenced this pull request Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants