Skip to content

1.5.0 bump #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2017
Merged

1.5.0 bump #81

merged 3 commits into from
Dec 11, 2017

Conversation

alda-optimizely
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.597% when pulling d053ec4 on 1.5.0-bump into 4c513ba on master.

mikeproeng37
mikeproeng37 approved these changes Dec 8, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mikeproeng37
mikeproeng37 reviewed Dec 9, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you gotta bump the version in the Gemspec file as well

@alda-optimizely
Copy link
Contributor Author

The gemspec refers to VERSION which is defined in https://github.com/optimizely/ruby-sdk/pull/81/files#diff-4ee21fe22c6530b8ca5cc6cbba691aca.

@optibot
Copy link

optibot commented Dec 11, 2017

Can one of the admins verify this patch?

@alda-optimizely alda-optimizely merged commit 3c93241 into master Dec 11, 2017
@alda-optimizely alda-optimizely deleted the 1.5.0-bump branch December 12, 2017 00:03
rashidsp pushed a commit to msohailhussain/ruby-sdk that referenced this pull request Dec 12, 2017
@alda-optimizely @rashidsp
Merge pull request optimizely#81 from optimizely/1.5.0-bump
31c4c39 
1.5.0 bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alda-optimizely @coveralls @optibot @mikeproeng37