Skip to content

[FSSDK-11371] parsing holdout section from the datafile #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 7, 2025
Merged

[FSSDK-11371] parsing holdout section from the datafile #577

merged 6 commits into from
Apr 7, 2025

Conversation

muzahidul-opti
Copy link
Contributor

Summary

  • Create a new Holdout model
  • Declare an ExperimentCore protocol to share common properties between Experiment and Holdout
  • Update the Experiment model to conform to ExperimentCore and align with shared properties.

Test plan

  • Holdout model test cases added

Issues

  • [FSSDK-11371]

@muzahidul-opti muzahidul-opti marked this pull request as ready for review March 21, 2025 11:06
@muzahidul-opti muzahidul-opti requested a review from jaeopt March 21, 2025 11:07
jaeopt
jaeopt requested changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions.

@muzahidul-opti muzahidul-opti requested a review from jaeopt March 25, 2025 16:02
jaeopt
jaeopt requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you confirm about Experiment in OptimizelyConfig?

@muzahidul-opti muzahidul-opti requested a review from jaeopt April 4, 2025 13:19
jaeopt
jaeopt approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 9d635dc into master Apr 7, 2025
9 of 12 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/holdout-FSSDK-11371 branch April 7, 2025 02:17
muzahidul-opti added a commit that referenced this pull request Apr 7, 2025
@muzahidul-opti
Merge branch 'master' into muzahid/FSSDK-11372
5404d97 
* master:
  [FSSDK-11371] parsing holdout section from the datafile (#577)

# Conflicts:
#	Sources/Data Model/ExperimentCore.swift
#	Sources/Data Model/Holdout.swift
muzahidul-opti added a commit that referenced this pull request Apr 7, 2025
@muzahidul-opti
Merge branch 'master' into fsc-hack
cf874c7 
* master:
  [FSSDK-11371] parsing holdout section from the datafile (#577)
  [FSSDK-11111] chore: update cocoapods version (#576)
  [FSSDK-11102] chore: replace travis-ci-tools repository (#571)
  ci(git-action): auto release prep for 5.1.0 (#575)
  [FSSDK-11111] chore: prepare release 5.1.0 (#574)
  [FSSDK-11036] chore: revert workflow branch to master (#572)
  [FSSDK-11036] fix: event tags support nested objects (#570)
muzahidul-opti added a commit that referenced this pull request Apr 7, 2025
@muzahidul-opti
Revert "[FSSDK-11371] parsing holdout section from the datafile (#577)"
d805536 
This reverts commit 9d635dc.
@muzahidul-opti muzahidul-opti mentioned this pull request Apr 7, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @jaeopt