refactor: Added ability to inject custom directory for DataStoreFile#612
Open
artesmichael wants to merge 5 commits intooptimizely:masterfrom
Open
refactor: Added ability to inject custom directory for DataStoreFile#612artesmichael wants to merge 5 commits intooptimizely:masterfrom
artesmichael wants to merge 5 commits intooptimizely:masterfrom
Conversation
Author
|
Hi @muzahidul-opti, could you please review this PR and let me know if any changes are required? |
|
lgtm |
Contributor
Sure, we will review it. |
Author
|
Hi @muzahidul-opti, are there any updates on this? |
Contributor
muzahidul-opti
left a comment
muzahidul-opti
left a comment
There was a problem hiding this comment.
Looks good to me, CI failing could you please fix it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataStoreFileto allow for injection of customFileManager.SearchPathDirectoryDefaultEventDispatcherto allow for injection of customFileManager.SearchPathDirectoryforDataStoreType.fileUsers have been raising the issue that they see these technical files inside of their
Filesapp, because the directory forDataStoreFiledefaults to.documentsDirectory, which is visible to users. This change allows us to update the directory to.applicationSupportDirectoryinDefaultEventDispatcherusingDataStoreType.file(directory: .applicationSupportDirectory)and inDefaultDatafileHandlerby overridingopen func createDataStore(sdkKey: String) -> OPTDataStore.Test plan
DataStoreFileIssues