Skip to content

[Feature] implement delete+insert incremental strategy #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
push2prod opened this issue Jan 17, 2024 · 2 comments
Closed

[Feature] implement delete+insert incremental strategy #128

push2prod opened this issue Jan 17, 2024 · 2 comments
Assignees
@aosingh
Labels
enhancement New feature or request

Comments

@push2prod
Copy link

Describe the Feature

implementation of delete+insert incremental strategy

Describe alternatives you've considered

using a pre hook on the model to delete the data or trying to implement the custom strategy myself, the first seems prone to error and the later convoluted

Who will this benefit?

dbt offers different strategies to make incremental models. the ones currently implemented are append and merge (as I understand). although they are not fit for all use cases. for example when reruns are desired and the table has no key

Anything else?

https://docs.getdbt.com/docs/build/incremental-models#about-incremental_strategy
@push2prod push2prod added the enhancement New feature or request label Jan 17, 2024
@aosingh aosingh self-assigned this Jan 17, 2024
aosingh added a commit that referenced this issue Mar 12, 2024
@aosingh
v1.7.3 changes
11695ff 
- Added support for Python 3.12
- oracledb driver upgraded to 2.1.0
- Added support for delete+insert incremental strategy addressing #128
- Added support for new config `partition_config`
@aosingh
Copy link
Member

aosingh commented Mar 12, 2024

@push2prod

We have added support for delete+insert incremental strategy in upcoming dbt-oracle release 1.7.3

Could you test it with the release candidate ?

pip install dbt-oracle==1.7.3rc2

@aosingh aosingh mentioned this issue Mar 12, 2024
Merged
@aosingh
Copy link
Member

aosingh commented Mar 20, 2024

@push2prod

Please test delete+insert incremental strategy with release 1.7.3

pip install dbt-oracle==1.7.3

aosingh added a commit that referenced this issue May 13, 2024
@aosingh
1.6-backports
82be460 
- Upgrade oracledb driver to v2.2.0
- Fix Oracle error: ORA-14452: attempt to create, alter or drop an index on temporary table already in use while using constraints with Incremental materialization. Issue discussed and fix verified in this slack thread : https://getdbt.slack.com/archives/C01PWH4TXLY/p1712669363630279
- Feature request [Feature] implement delete+insert incremental strategy #128
- Support for new partition_config in table and incremental materialization
@aosingh aosingh mentioned this issue May 13, 2024
Merged
@aosingh aosingh closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aosingh aosingh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aosingh @push2prod