Exclude substituted class from build time initialization #2935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziyilin
force-pushed
the
noSubstitutionClinit
branch
from
ed84605 to
47ad520
Compare
vjovanov
reviewed
Oct 22, 2020
| @@ -216,7 +221,18 @@ private boolean isInvokeUnsafeIterative(InvokeTypeFlow i) { | |||
| } | |||
|
|
|||
| private void addInitializer(AnalysisType t) { | |||
| types.put(t, initialTypeInitializerSafety(t)); | |||
| ResolvedJavaType rt = t.getWrappedWithoutResolve(); | |||
There was a problem hiding this comment.
I would put this whole block in initialTypeInitializerSafety.
|
Otherwise, LGTM. |
What is LGTM short for? |
The class substituted with @substitute or @delete annotation should not be initialized at build time because it will not appear in the run time. It makes no sense to put it in the native heap but causing initialization errors.
ziyilin
force-pushed
the
noSubstitutionClinit
branch
from
47ad520 to
30bb408
Compare
LGTM = Looks Good To Me |
|
This fix has been integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class substituted with
@Substituteor@Deleteannotation should not be initialized at build time because it will not appear at run time. It makes no sense to put it in the native heap but causing initialization errors.This patch fixes the issue #2936