-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Debugtypes #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Debugtypes #3046
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e3006a2
Basic cut of DebugTypeInfo interface and implementation
adinn b307ee8
Update debug info model to include details of types
adinn 9c5f215
Switch C++ mapping to use Java names for base types and pointers for …
adinn 9757c9c
Fix conversion of indirect to war oops using wrapper subclasses
adinn 2061867
Make arrays subtype object and include length as a local field
adinn 2c3c8ab
Correct debug info test script for new object layout and to bypass la…
adinn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
63 changes: 63 additions & 0 deletions
63
...ratevm/src/com.oracle.objectfile/src/com/oracle/objectfile/debugentry/ArrayTypeEntry.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* | ||
* Copyright (c) 2020, 2020, Oracle and/or its affiliates. All rights reserved. | ||
* Copyright (c) 2020, 2020, Red Hat Inc. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. Oracle designates this | ||
* particular file as subject to the "Classpath" exception as provided | ||
* by Oracle in the LICENSE file that accompanied this code. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
package com.oracle.objectfile.debugentry; | ||
|
||
import com.oracle.objectfile.debuginfo.DebugInfoProvider.DebugArrayTypeInfo; | ||
import com.oracle.objectfile.debuginfo.DebugInfoProvider.DebugTypeInfo; | ||
import com.oracle.objectfile.debuginfo.DebugInfoProvider.DebugTypeInfo.DebugTypeKind; | ||
import org.graalvm.compiler.debug.DebugContext; | ||
|
||
public class ArrayTypeEntry extends StructureTypeEntry { | ||
private TypeEntry elementType; | ||
private int baseSize; | ||
private int lengthOffset; | ||
|
||
public ArrayTypeEntry(String typeName, int size) { | ||
super(typeName, size); | ||
} | ||
|
||
@Override | ||
public DebugTypeKind typeKind() { | ||
return DebugTypeKind.ARRAY; | ||
} | ||
|
||
@Override | ||
public void addDebugInfo(DebugInfoBase debugInfoBase, DebugTypeInfo debugTypeInfo, DebugContext debugContext) { | ||
DebugArrayTypeInfo debugArrayTypeInfo = (DebugArrayTypeInfo) debugTypeInfo; | ||
String elementTypeName = TypeEntry.canonicalize(debugArrayTypeInfo.elementType()); | ||
this.elementType = debugInfoBase.lookupTypeEntry(elementTypeName); | ||
this.baseSize = debugArrayTypeInfo.baseSize(); | ||
this.lengthOffset = debugArrayTypeInfo.lengthOffset(); | ||
/* Add details of fields and field types */ | ||
debugArrayTypeInfo.fieldInfoProvider().forEach(debugFieldInfo -> this.processField(debugFieldInfo, debugInfoBase, debugContext)); | ||
debugContext.log("typename %s element type %s base size %d length offset %d\n", typeName, elementTypeName, baseSize, lengthOffset); | ||
} | ||
|
||
public TypeEntry getElementType() { | ||
return elementType; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.