Showcase how to dump locals info via debuginfo #4227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olpaw
reviewed
Jan 18, 2022
| @@ -278,6 +284,48 @@ public String toString() { | |||
| return String.format("-%s, span %d, bci %d, method %s", getPosStr(), getSpan(), frame.getBCI(), frame.getMethod().format("%h.%n(%p)")); | |||
| } | |||
|
|
|||
| public String getLocalsStr() { | |||
There was a problem hiding this comment.
@adinn this is a hopefully more correct example code how to get locals info for the CompilationResultFrameTree
There was a problem hiding this comment.
@olpaw Thanks. I'll work that into something that communicates the frame tree content to the debug info generation code.
olpaw
reviewed
Jan 19, 2022
| Local[] locals = lvt.getLocals(); | ||
| if (locals != null && locals.length > 0) { | ||
| nonEmptySortedLocals = Arrays.copyOf(locals, locals.length); | ||
| Arrays.sort(nonEmptySortedLocals, (Local l1, Local l2) -> l1.getSlot() - l2.getSlot()); |
There was a problem hiding this comment.
Arrays.sort(nonEmptySortedLocals, Comparator.comparingInt(Local::getSlot)); is clearly more elegant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.