Add initial set of hibernate 7.0 metadata #579
Conversation
Hibernate 7 is still in beta, still if there's a need to early test integration this is a least some metadata that allows to bootstrap hibernate.
christophstrobl
force-pushed
the
labs/hibernate-7.0
branch
from
f96d012 to
3875324
Compare
christophstrobl
changed the title
Make sure hibernate 6.6.x versions are routed to the 6.6 metadata.
|
@dnestoro Could you please review, squash and merge this PR? |
| } catch (Exception e) { | ||
| Throwable rootCause = getRootCause(e); | ||
| if (rootCause instanceof UnsupportedOperationException || rootCause instanceof NullPointerException) { | ||
| // this is fine - trust me I'm an engineer! |
There was a problem hiding this comment.
Please replace this comment with the actual reason why we are suppressing UnsupportedOperationException and NullPointerException here.
It must possible to write a more useful comment than:
this is fine - trust me I'm an engineer!
There was a problem hiding this comment.
This is a test that tries to emulate what hibernate does at runtime in certain areas so that we can extract the metadata. We need to essentially capture the method call and it's not always possible, at least with a reasonable amount of work, to build the test in a way so that hibernate internals would not bark at the provided input parameters in some cases.
Sure I can put this in as the comment as well, or just remove it. Whatever you prefer.
There was a problem hiding this comment.
Sure I can put this in as the comment as well
Yes, that would be much appreciated.
...core/7.0.0.Final/src/test/java/org_hibernate_orm/hibernate_core/OrmAnnotationHelperTest.java
Show resolved
Hide resolved
...core/7.0.0.Final/src/test/java/org_hibernate_orm/hibernate_core/OrmAnnotationHelperTest.java
Show resolved
Hide resolved
...core/7.0.0.Final/src/test/java/org_hibernate_orm/hibernate_core/OrmAnnotationHelperTest.java
Show resolved
Hide resolved
| @@ -0,0 +1,24 @@ | |||
| [ | |||
There was a problem hiding this comment.
Why do we have generated-metadata pushed here?
If I understand correctly, you generated metadata, cleaned it, and then copy it to the metadata/org.hibertane.orm/.... Why do we need this generated metadata here?
There was a problem hiding this comment.
good catch - thanks yeah those files can be removed 👍
There was a problem hiding this comment.
Hum, missed that sorry, can you update the PR @christophstrobl, and I will then do a new round of tests?
What does this PR do?
Hibernate 7 is finally out and this PR contains some metadata that allows to bootstrap hibernate.
Code sections where the PR accesses files, network, docker or some external service
Checklist before merging