Fix reciprocal of a complex number with zero imaginary part #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangeduck
added a commit
that referenced
this pull request
Jun 13, 2015
Fix reciprocal of a complex number with zero imaginary part
|
Thanks. I've merged this in. Hopefully there will be a merge into sloisel's repo at some point so it can be included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reciprocal function is broken when applied to a complex number with zero imaginary part. The code path forgot to use a namespace for the result, and also forgot to include the imaginary part of the result. I added a suitable test case to the documentation to check for this. The missing namespace was found by jshint, the missing imaginary part then exposed by the unit test I had added.
I filed this as sloisel#59 but apparently that repository is largely unmaintained. Yours appears to be in a much better shape.