This repository was archived by the owner on Apr 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Implement File Store #43
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
501cd29
file store
Wwwsylvia e02b9c8
draft get
Wwwsylvia 8a059dc
fix test
Wwwsylvia b028482
improvement
Wwwsylvia e61d317
draft put
Wwwsylvia c132d37
refactor put
Wwwsylvia 1fa25cf
draft delete
Wwwsylvia 9ec9a1a
fix
Wwwsylvia 6711216
test get
Wwwsylvia f25afb8
clean up
Wwwsylvia 23f4f98
test put
Wwwsylvia 3123148
remove not found error
Wwwsylvia 2cb14e4
draft encode/decode
Wwwsylvia 7a010c0
test decode
Wwwsylvia 5662d0c
fix get username password
Wwwsylvia 6399b9f
improvement and TODOs
Wwwsylvia 1f619a9
more test cases
Wwwsylvia 0bb94eb
improve unit tests
Wwwsylvia 93f93f5
fix savefile
Wwwsylvia 10ef4a9
document variables
Wwwsylvia e14d1c4
rename temp file
Wwwsylvia 5d1ab3e
minor fix test data
Wwwsylvia 3afa112
fix new
Wwwsylvia 81cd939
minor improve coverage
Wwwsylvia 3a35144
omit empty
Wwwsylvia 34882d3
change test auth config type
Wwwsylvia e66df92
empty line
Wwwsylvia c1ab88e
rename
Wwwsylvia 724e510
ingest
Wwwsylvia b021344
add reference comment
Wwwsylvia be237e3
use json.RawMessage
Wwwsylvia 5500dad
refactor
Wwwsylvia 8541222
extract
Wwwsylvia ebe4f8b
optimize decoding
Wwwsylvia 2ceda3e
remove unnecessary functions
Wwwsylvia ae78e11
add auths cache
Wwwsylvia dbb8dd2
refactor
Wwwsylvia e951fb5
clean up
Wwwsylvia 4952d07
refactors per comments
Wwwsylvia 0bd4c81
improvements per comments
Wwwsylvia 28a0d26
more improvements
Wwwsylvia 76fa5ed
rename testdata
Wwwsylvia 1db937c
improve testdata
Wwwsylvia 7b9d4a1
address comments
Wwwsylvia b3f9fd5
fix
Wwwsylvia 571dba0
check close error
Wwwsylvia f3eaeb0
fix error check
Wwwsylvia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,249 @@ | ||
| /* | ||
| Copyright The ORAS Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package credentials | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "context" | ||
| "encoding/base64" | ||
| "encoding/json" | ||
| "errors" | ||
| "fmt" | ||
| "os" | ||
| "path/filepath" | ||
| "strings" | ||
| "sync" | ||
|
|
||
| "github.com/oras-project/oras-credentials-go/internal/ioutil" | ||
| "oras.land/oras-go/v2/registry/remote/auth" | ||
| ) | ||
|
|
||
| // FileStore implements a credentials store using the docker configuration file | ||
| // to keep the credentials in plain-text. | ||
| type FileStore struct { | ||
| // DisablePut disables putting credentials in plaintext. | ||
| // If DisablePut is set to true, Put() will return ErrPlaintextPutDisabled. | ||
| DisablePut bool | ||
|
|
||
| // configPath is the path to the config file. | ||
| configPath string | ||
| // content is the content of the config file. | ||
| // Reference: https://github.com/docker/cli/blob/v24.0.0-beta.1/cli/config/configfile/file.go#L17-L45 | ||
| content map[string]json.RawMessage | ||
| // authsCache is a cache of the auths field of the config field. | ||
| // Reference: https://github.com/docker/cli/blob/v24.0.0-beta.1/cli/config/configfile/file.go#L19 | ||
| authsCache map[string]json.RawMessage | ||
| // rwLock is a read-write-lock for the file store. | ||
| rwLock sync.RWMutex | ||
| } | ||
|
|
||
| // configFieldAuths is the "auths" field in the config file. | ||
| // Reference: https://github.com/docker/cli/blob/v24.0.0-beta.1/cli/config/configfile/file.go#L19 | ||
| const configFieldAuths = "auths" | ||
|
|
||
| var ( | ||
| // ErrInvalidConfigFormat is returned when the config format is invalid. | ||
| ErrInvalidConfigFormat = errors.New("invalid config format") | ||
| // ErrPlaintextPutDisabled is returned by Put() when DisablePut is set | ||
| // to true. | ||
| ErrPlaintextPutDisabled = errors.New("putting plaintext credentials is disabled") | ||
| ) | ||
|
|
||
| // authConfig contains authorization information for connecting to a Registry. | ||
| // References: | ||
| // - https://github.com/docker/cli/blob/v24.0.0-beta.1/cli/config/configfile/file.go#L17-L45 | ||
| // - https://github.com/docker/cli/blob/v24.0.0-beta.1/cli/config/types/authconfig.go#L3-L22 | ||
| type authConfig struct { | ||
| // Auth is a base64-encoded string of "{username}:{password}". | ||
| Auth string `json:"auth,omitempty"` | ||
| // IdentityToken is used to authenticate the user and get. | ||
| // an access token for the registry. | ||
| IdentityToken string `json:"identitytoken,omitempty"` | ||
| // RegistryToken is a bearer token to be sent to a registry. | ||
| RegistryToken string `json:"registrytoken,omitempty"` | ||
|
|
||
| Username string `json:"username,omitempty"` // legacy field for compatibility | ||
| Password string `json:"password,omitempty"` // legacy field for compatibility | ||
| } | ||
|
|
||
| // newAuthConfig creates an authConfig based on cred. | ||
| func newAuthConfig(cred auth.Credential) authConfig { | ||
| return authConfig{ | ||
| Auth: encodeAuth(cred.Username, cred.Password), | ||
| IdentityToken: cred.RefreshToken, | ||
| RegistryToken: cred.AccessToken, | ||
| } | ||
| } | ||
|
|
||
| // Credential returns an auth.Credential based on ac. | ||
| func (ac authConfig) Credential() (auth.Credential, error) { | ||
| cred := auth.Credential{ | ||
| Username: ac.Username, | ||
| Password: ac.Password, | ||
| RefreshToken: ac.IdentityToken, | ||
| AccessToken: ac.RegistryToken, | ||
| } | ||
| if ac.Auth != "" { | ||
| var err error | ||
| // override username and password | ||
| cred.Username, cred.Password, err = decodeAuth(ac.Auth) | ||
| if err != nil { | ||
| return auth.EmptyCredential, fmt.Errorf("failed to decode auth field: %w: %v", ErrInvalidConfigFormat, err) | ||
| } | ||
| } | ||
| return cred, nil | ||
| } | ||
|
|
||
| // NewFileStore creates a new file credentials store. | ||
| func NewFileStore(configPath string) (*FileStore, error) { | ||
| fs := &FileStore{configPath: configPath} | ||
| configFile, err := os.Open(configPath) | ||
| if err != nil { | ||
| if os.IsNotExist(err) { | ||
| // init content map and auths cache if the content file does not exist | ||
| fs.content = make(map[string]json.RawMessage) | ||
| fs.authsCache = make(map[string]json.RawMessage) | ||
| return fs, nil | ||
| } | ||
| return nil, fmt.Errorf("failed to open config file at %s: %w", configPath, err) | ||
| } | ||
| defer configFile.Close() | ||
|
|
||
| // decode config content if the config file exists | ||
| if err := json.NewDecoder(configFile).Decode(&fs.content); err != nil { | ||
| return nil, fmt.Errorf("failed to decode config file at %s: %w: %v", configPath, ErrInvalidConfigFormat, err) | ||
| } | ||
| authsBytes, ok := fs.content[configFieldAuths] | ||
| if !ok { | ||
| // init auths cache | ||
| fs.authsCache = make(map[string]json.RawMessage) | ||
| return fs, nil | ||
| } | ||
| if err := json.Unmarshal(authsBytes, &fs.authsCache); err != nil { | ||
| return nil, fmt.Errorf("failed to unmarshal auths field: %w: %v", ErrInvalidConfigFormat, err) | ||
| } | ||
| return fs, nil | ||
| } | ||
|
|
||
| // Get retrieves credentials from the store for the given server address. | ||
| func (fs *FileStore) Get(_ context.Context, serverAddress string) (auth.Credential, error) { | ||
| fs.rwLock.RLock() | ||
| defer fs.rwLock.RUnlock() | ||
|
|
||
| authCfgBytes, ok := fs.authsCache[serverAddress] | ||
| if !ok { | ||
| return auth.EmptyCredential, nil | ||
| } | ||
| var authCfg authConfig | ||
| if err := json.Unmarshal(authCfgBytes, &authCfg); err != nil { | ||
| return auth.EmptyCredential, fmt.Errorf("failed to unmarshal auth field: %w: %v", ErrInvalidConfigFormat, err) | ||
| } | ||
| return authCfg.Credential() | ||
| } | ||
|
|
||
| // Put saves credentials into the store for the given server address. | ||
| // Returns ErrPlaintextPutDisabled if fs.DisablePut is set to true. | ||
| func (fs *FileStore) Put(_ context.Context, serverAddress string, cred auth.Credential) error { | ||
| if fs.DisablePut { | ||
| return ErrPlaintextPutDisabled | ||
| } | ||
|
|
||
| fs.rwLock.Lock() | ||
| defer fs.rwLock.Unlock() | ||
|
|
||
| authCfg := newAuthConfig(cred) | ||
| authCfgBytes, err := json.Marshal(authCfg) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to marshal auth field: %w", err) | ||
| } | ||
| fs.authsCache[serverAddress] = authCfgBytes | ||
| return fs.saveFile() | ||
| } | ||
|
|
||
| // Delete removes credentials from the store for the given server address. | ||
| func (fs *FileStore) Delete(_ context.Context, serverAddress string) error { | ||
| fs.rwLock.Lock() | ||
| defer fs.rwLock.Unlock() | ||
|
|
||
| if _, ok := fs.authsCache[serverAddress]; !ok { | ||
| // no ops | ||
| return nil | ||
| } | ||
| delete(fs.authsCache, serverAddress) | ||
| return fs.saveFile() | ||
| } | ||
|
|
||
| // saveFile saves fs.content into fs.configPath. | ||
| func (fs *FileStore) saveFile() (returnErr error) { | ||
| // marshal content | ||
| authsBytes, err := json.Marshal(fs.authsCache) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to marshal credentials: %w", err) | ||
| } | ||
| fs.content[configFieldAuths] = authsBytes | ||
| jsonBytes, err := json.MarshalIndent(fs.content, "", "\t") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to marshal config: %w", err) | ||
| } | ||
|
|
||
| // write the content to a ingest file for atomicity | ||
| configDir := filepath.Dir(fs.configPath) | ||
| if err := os.MkdirAll(configDir, 0700); err != nil { | ||
| return fmt.Errorf("failed to make directory %s: %w", configDir, err) | ||
| } | ||
| ingest, err := ioutil.Ingest(configDir, bytes.NewReader(jsonBytes)) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to save config file: %w", err) | ||
| } | ||
| defer func() { | ||
| if returnErr != nil { | ||
| // clean up the ingest file in case of error | ||
| os.Remove(ingest) | ||
| } | ||
| }() | ||
|
|
||
| // overwrite the config file | ||
| if err := os.Rename(ingest, fs.configPath); err != nil { | ||
| return fmt.Errorf("failed to save config file: %w", err) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // encodeAuth base64-encodes username and password into base64(username:password). | ||
| func encodeAuth(username, password string) string { | ||
| if username == "" && password == "" { | ||
| return "" | ||
| } | ||
| return base64.StdEncoding.EncodeToString([]byte(username + ":" + password)) | ||
| } | ||
|
|
||
| // decodeAuth decodes a base64 encoded string and returns username and password. | ||
| func decodeAuth(authStr string) (username string, password string, err error) { | ||
| if authStr == "" { | ||
| return "", "", nil | ||
| } | ||
|
|
||
| decoded, err := base64.StdEncoding.DecodeString(authStr) | ||
| if err != nil { | ||
| return "", "", err | ||
| } | ||
| decodedStr := string(decoded) | ||
| username, password, ok := strings.Cut(decodedStr, ":") | ||
| if !ok { | ||
| return "", "", fmt.Errorf("auth '%s' does not conform the base64(username:password) format", decodedStr) | ||
| } | ||
| return username, password, nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.