Skip to content

refactor: remove AutoRemoveReferrers flag#683

Merged
Wwwsylvia merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:flags
Jan 26, 2024
Merged

refactor: remove AutoRemoveReferrers flag#683
Wwwsylvia merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:flags

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

following #680 and addressing this comment: #680 (comment)

@codecov

codecov Bot commented Jan 19, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa548ab) 75.92% compared to head (78c40fd) 75.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   75.92%   75.92%   -0.01%     
==========================================
  Files          59       59              
  Lines        5874     5873       -1     
==========================================
- Hits         4460     4459       -1     
  Misses       1037     1037              
  Partials      377      377              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT changed the title feat: remove AutoRemoveReferrers flag revert: remove AutoRemoveReferrers flag Jan 23, 2024
@shizhMSFT shizhMSFT changed the title revert: remove AutoRemoveReferrers flag feat: remove AutoRemoveReferrers flag Jan 23, 2024
@shizhMSFT

Copy link
Copy Markdown
Contributor

The AutoRemoveReferrers flag was introduced in #653

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia

Copy link
Copy Markdown
Member

Wondering if this is a refactor?

@wangxiaoxuan273 wangxiaoxuan273 changed the title feat: remove AutoRemoveReferrers flag refactor: remove AutoRemoveReferrers flag Jan 25, 2024

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread content/oci/oci.go Outdated
Comment thread content/oci/oci.go Outdated
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia
Wwwsylvia merged commit 850a247 into oras-project:main Jan 26, 2024
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
4 tasks
@wangxiaoxuan273
wangxiaoxuan273 deleted the flags branch March 6, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants