Skip to content

build(deps): bump golang.org/x/sync from 0.6.0 to 0.7.0#738

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/golang.org/x/sync-0.7.0
Closed

build(deps): bump golang.org/x/sync from 0.6.0 to 0.7.0#738
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/golang.org/x/sync-0.7.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Apr 4, 2024

Copy link
Copy Markdown
Contributor

Bumps golang.org/x/sync from 0.6.0 to 0.7.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.6.0 to 0.7.0.
- [Commits](golang/sync@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 4, 2024
@codecov

codecov Bot commented Apr 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.17%. Comparing base (9b6f321) to head (f89b2c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
+ Coverage   75.85%   76.17%   +0.32%     
==========================================
  Files          63       59       -4     
  Lines        6000     5885     -115     
==========================================
- Hits         4551     4483      -68     
+ Misses       1069     1028      -41     
+ Partials      380      374       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks some unit tests, interesting.

@wangxiaoxuan273

wangxiaoxuan273 commented Apr 7, 2024

Copy link
Copy Markdown
Contributor

The unit test cases MountFrom error and MountFrom OnMounted error sometimes fail, because the values of the fields become undeterministic with golang.org/x/sync 0.7.0. This is caused by goroutine cancelling after a new goroutine has been created, therefore the fields may be visited by a different number of goroutines. Posted PR #739 to fix.

Wwwsylvia pushed a commit that referenced this pull request Apr 8, 2024
To fix #738

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@dependabot @github

dependabot Bot commented on behalf of github Apr 8, 2024

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/go_modules/golang.org/x/sync-0.7.0 branch April 8, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants