fix: add missing operation to fs path error#799
Merged
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
requested review from
SteveLasker,
Wwwsylvia,
sajayantony and
shizhMSFT
as code owners
July 25, 2024 07:14
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
==========================================
- Coverage 77.92% 77.88% -0.05%
==========================================
Files 63 63
Lines 4694 4694
==========================================
- Hits 3658 3656 -2
- Misses 656 657 +1
- Partials 380 381 +1 ☔ View full report in Codecov by Sentry. |
Wwwsylvia
reviewed
Jul 25, 2024
shizhMSFT
reviewed
Jul 25, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening a folder as OCI image layout and there is no
oci-layoutfile exists, the error would beThere is a duplicated space in the error string, because the
Opfield is missing in the returnedfs.PathError. With fix in this PR, the return error would beFixes #640