chore: update to image-spec v1.1.1#909
Merged
Merged
Conversation
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Wwwsylvia
requested review from
SteveLasker,
sajayantony and
shizhMSFT
as code owners
March 4, 2025 09:08
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
- Coverage 80.24% 80.19% -0.05%
==========================================
Files 63 63
Lines 6053 6053
==========================================
- Hits 4857 4854 -3
- Misses 858 860 +2
- Partials 338 339 +1 ☔ View full report in Codecov by Sentry. |
2 tasks
Contributor
There was a problem hiding this comment.
PR Overview
This PR updates documentation and code comments to reference image‑spec v1.1.1 along with related distribution‑spec links. It also adjusts the media type regular expression to reflect the new specification.
- Updated references across comments in various files from v1.1.0 to v1.1.1.
- Modified the mediaTypeRegexp in pack.go to match the new image‑spec.
- Updated documentation links in registry and content packages to point to the new spec versions.
Reviewed Changes
| File | Description |
|---|---|
| pack.go | Updated image‑spec documentation and mediaTypeRegexp |
| registry/remote/repository.go | Updated distribution‑spec references |
| registry/remote/errcode/errors.go | Updated error code documentation links |
| registry/repository.go | Updated image‑spec references in comments |
| registry/remote/warning.go | Updated warning reference links |
| content/oci/readonlystorage.go | Updated image layout reference |
| registry/reference.go | Updated references for pulling manifests |
| content/oci/oci.go | Updated image layout references |
| registry/remote/registry.go | Updated registry API reference |
| example_pack_test.go | Updated image‑spec version reference in test example |
| content/oci/storage.go | Updated image layout reference in comments |
| content/oci/readonlyoci.go | Updated image layout reference |
| registry/remote/referrers.go | Updated referrers API documentation references |
| registry/remote/url.go | Updated URLs documentation references |
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
pack.go:115
- [nitpick] Please verify that the reordering in the mediaTypeRegexp character class accurately reflects the pattern defined in image‑spec v1.1.1 to avoid any unintended matching issues.
var mediaTypeRegexp = regexp.MustCompile(`^[A-Za-z0-9][A-Za-z0-9!#$&^_.+-]{0,126}/[A-Za-z0-9][A-Za-z0-9!#$&^_.+-]{0,126}$`)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image-spec v1.1.1inpack.goimage-spec v1.1.1anddistribution-spec v1.1.1Resolves: #910