Skip to content

Fix bug with inline comment#168

Merged
orchestr7 merged 4 commits into
orchestr7:mainfrom
BOOMeranGG:fix-symbols-in-inline-comment
Dec 13, 2022
Merged

Fix bug with inline comment#168
orchestr7 merged 4 commits into
orchestr7:mainfrom
BOOMeranGG:fix-symbols-in-inline-comment

Conversation

@BOOMeranGG

@BOOMeranGG BOOMeranGG commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

Fix #167

@BOOMeranGG BOOMeranGG changed the title Rewrite takeBeforeComment and trimComment functions Fix bug with inline comment Dec 8, 2022
@BOOMeranGG
BOOMeranGG force-pushed the fix-symbols-in-inline-comment branch from 7967559 to b7fd07a Compare December 8, 2022 21:19
Comment thread ktoml-core/src/commonMain/kotlin/com/akuleshov7/ktoml/parsers/StringUtils.kt Outdated
@NightEule5
NightEule5 requested a review from orchestr7 December 8, 2022 22:01
@BOOMeranGG

Copy link
Copy Markdown
Collaborator Author

@akuleshov7 Previous time one check failed. Is something wrong?

@orchestr7

Copy link
Copy Markdown
Owner

@akuleshov7 Previous time one check failed. Is something wrong?
approved run, let me check. Have you run ./gradlew diktatFixAll or ./gradlew detekt tasks?

@BOOMeranGG

Copy link
Copy Markdown
Collaborator Author

Have you run ./gradlew diktatFixAll or ./gradlew detekt tasks?
Yes, I have. It's all right. Let's merge?

@orchestr7
orchestr7 merged commit d0a121d into orchestr7:main Dec 13, 2022
@orchestr7

Copy link
Copy Markdown
Owner

Have you run ./gradlew diktatFixAll or ./gradlew detekt tasks?
Yes, I have. It's all right. Let's merge?

Great, thank you so much for this fix!

@BOOMeranGG
BOOMeranGG deleted the fix-symbols-in-inline-comment branch December 13, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug with " symbol in inline comment

3 participants