fix: resolve stack overflow on deeply nested arrays (#381)#388
Open
gildor wants to merge 1 commit into
Open
Conversation
gildor
marked this pull request as ready for review
July 2, 2026 05:10
Rewrite hasClosedMultilineArray() to use bracket-balance counting instead of naive end-detection, fixing deeply nested arrays and tricky comments. - TomlMultilineString: bracket-balance end detection - TomlArray: trim leading whitespace before bracket removal - Add regression tests (Issue381Test) - Remove StackOverflowOnNesting from baseline (cherry picked from commit b9f3644)
gildor
force-pushed
the
fix/stackoverflow-nested-381
branch
from
July 2, 2026 05:27
37a471e to
654d941
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381 (the stack overflow).
Deeply nested arrays could overflow the stack because multiline-array end detection used a "does the joined string end with
]]" check. This rewrites it to bracket-balance counting that ignores brackets inside quoted strings.TomlArray: trim leading whitespace before bracket removalTomlMultilineString:hasClosedMultilineArray()- balance[/]outside quotes to decide when a multiline array is closedIssue381Test: regression coverage (nested arrays + inline-comment edge cases)Compliance suite:
valid/array/nested-double.tomlnow passes and is removed from the baseline.valid/comment/tricky.tomlno longer overflows either, but it still fails on unrelated value/comment handling (floats-with-comments like10e2#1, etc.), so it stays baselined under #381 for a separate follow-up rather than being falsely marked as passing.