-
Notifications
You must be signed in to change notification settings - Fork 145
Add location picking feature #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@oriash93 bringing your attention to this PR, hopefully it can get merged in relatively soon as it's a helpful feature when wanting to click in a specific spot on screen. |
… where the primary monitor has a negative X coordinate. Also added information logging.
…itor has a negative offset.
Based on my testing the only bug I found is for the rare scenario where the user's primary screen is configured with a negative offset. In the horizontal layout configured as seen below (screen 1 is primary). The bug is that the capture window does not draw fully across screen 2. See below. A note about the above image: For some reason the Snipping Tool and Print Screen functions capture things backwards. In the screenshot showing the bug the screen where the window was only rendered halfway across is Screen 2 in the display configuration screenshot... In a vertical layout configured as seen below (screen 1 is primary). The bug is that the capture window does not draw fully across screen 1. See below. To provide further documentation on the oddity of this bug, I have two identical monitors. Same make/model, same resolution, same physical size. When specifing the primary screen with a negative offset and setting the correct Width/Height and Top/Left values of the mouse capture window, Windows or the .NET framework changes the window size at runtime when the window is rendered. I'm not sure why... See below. I have two screens that are 3840x2160 resolution, as you can see I calculated the correct total width of the window (7680px) yet the rendered window size is 5137.33px.
I went into the live tree viewer and manually changed the width to 7680 and nothing happened as far as the window size increasing in width. If I set the window value to something less than 5137.33 than the window width actually reduces in size in real time. Something is capping it and I don't know why. |
…tructor, perform less loops over the screen array.
…cally check the "PickedLocation" radio button.
…ordinates were captured.
Hey @reloaded! first of all, thanks a lot for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review in the meantime, great work so far!
@oriash93 I took care of your suggestions & requests. Go ahead and give it another look. If Github gives you the option to do so, you should ensure this PR is merged in via a Squash merge. That way your main branch only has a single commit that brings in this feature and keeps your commit history clean. |
@oriash93 bump, do you have time to finish reviewing this PR? |
Hey @reloaded sorry for the delay. I plan to review and merge by the end of this week :) |
Great. |
@reloaded Thank you so much for your contribution! |
#1 Add location picking feature
The following scenarios have been tested with no issues.
1 monitor.
2 monitors, horizontally (see below).

2 monitors, vertically (see below).

2 monitors, horizontally, but one has a Y offset (see below).

2 monitors, vertically, but one has a X offset (see below).

The following scenarios have been tested, but with some issues.
The following scenarios have not been tested.