python,cmake: update version script to support rc #3979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@anagainaru this will fix the error that you are observing in your PR |
vicentebolea
force-pushed
the
adios2-version-fix
branch
from
c0c88dd to
a5dd5b6
Compare
anagainaru
previously approved these changes
Jan 2, 2024
Member
anagainaru
left a comment
anagainaru
left a comment
There was a problem hiding this comment.
I am not the best to review this so maybe wait for Scott to review (I'll approve in case you are confident in this). I'll rebase my PR once this is merged
vicentebolea
force-pushed
the
adios2-version-fix
branch
from
a5dd5b6 to
19a7c35
Compare
Collaborator
Author
|
Scott is off until thursday, you can merge this and have it reverted if it causes trouble |
anagainaru
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.