Reorg Remote as base class in preparation for more remote subclasses #4162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagainaru
approved these changes
May 13, 2024
Member
anagainaru
left a comment
anagainaru
left a comment
There was a problem hiding this comment.
I didn't realize initially you are just reorganizing things and the EVPathRemote looked very familiar haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes here. Just reshuffling the code so that we can subclass remote for various underlying protocols. This doesn't change any interactions with the current EVPath based remote adios server, but it sets the stage to have an Xroot-based remote protocol implementation without overly disrupting the places these calls are made.