Don't print kvcache connection closed message when it was not opened. #4251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagainaru
previously approved these changes
Jul 19, 2024
Member
anagainaru
left a comment
anagainaru
left a comment
There was a problem hiding this comment.
Is this the reason all the CIs failed in the previous PR?
Contributor
Author
|
Yes |
Member
|
When this is merged you need to enable kvcache back (#4256 disabled it). |
pnorbert
force-pushed
the
fix-kvcache-config
branch
from
4dd3da9 to
0144a22
Compare
vicentebolea
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.