Updating very old tests #4317
Merged
Updating very old tests #4317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@anagainaru finally cleaned up mistaken substitutions here. Should be ready to go. |
anagainaru
approved these changes
Aug 22, 2024
Member
anagainaru
left a comment
anagainaru
left a comment
There was a problem hiding this comment.
There are some references to B4 in the documentation of heatmap as well if you want to update everything:
The ADIOS2 executable needs an XML config file to select the Engine used for the output. The engines are: File, BP4 and HDF5, the corresponding XML config files are in the examples/simulations/heatTransfer/ directory. The "File" engine will be BP4 or HDF5 depending on the extension of the file name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were tests in testing/examples/heatTransfer that hadn't been updated forever. I.E. they were testing BP3/4, but not 5, were testing SST with BP and FFS marshalling methods (neither maintained), etc. This PR simplifies a bit, reduces SST testing to the default marshalling method, switches out bp3 and adds bp5.